Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example of using fsspec for large batch inference #1927

Merged
merged 9 commits into from
Oct 28, 2022

Conversation

kirkpa
Copy link
Contributor

@kirkpa kirkpa commented Oct 27, 2022

Description

This change adds an example of using fsspec to retrieve data from cloud storage for batch inference using large batch size.

Addresses #1891

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

No testing required since this is adding an example. Instructions to run the example provided in README.md.

@kirkpa kirkpa changed the title Adding an example of using of fsspec for large batch inference Adding an example of using fsspec for large batch inference Oct 27, 2022
@agunapal
Copy link
Collaborator

@kirkpa Thanks for the PR. This is great. Please check https://github.com/serve/blob/master/CONTRIBUTING.md and make sure to run the precommit command for lint

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1927 (d02cecd) into master (942d0e8) will not change coverage.
The diff coverage is n/a.

❗ Current head d02cecd differs from pull request most recent head 7f37e8e. Consider uploading reports for the commit 7f37e8e to get more accurate results

@@           Coverage Diff           @@
##           master    #1927   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning
Copy link
Collaborator

lxning commented Oct 28, 2022

@kirkpa This is a great contribution. could you please provide a test log for this example? Thanks.

@kirkpa
Copy link
Contributor Author

kirkpa commented Oct 28, 2022

@kirkpa This is a great contribution. could you please provide a test log for this example? Thanks.

I've provided snippet of the output generated when running the example in README.md.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@msaroufim msaroufim merged commit 87fcb51 into pytorch:master Oct 28, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
…1927)

* Adding cloud storage stream inference

* working python example code

* Updated README

* Updated README

* Addressing code review comments

* Fixing lint errors

* pre-commit updates

* fixed spelling
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
…1927)

* Adding cloud storage stream inference

* working python example code

* Updated README

* Updated README

* Addressing code review comments

* Fixing lint errors

* pre-commit updates

* fixed spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants