Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gradle deprecation method #1936

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix gradle deprecation method #1936

merged 2 commits into from
Nov 2, 2022

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Nov 1, 2022

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fix gradle warnings as the following:

he RepositoryHandler.jcenter() method has been deprecated. This is scheduled to be removed in Gradle 8.0. JFrog announced JCenter's sunset in February 2021. Use mavenCentral() instead. Consult the upgrading guide for further information: https://docs.gradle.org/7.3/userguide/upgrading_version_6.html#jcenter_deprecation
        at build_ensecnpt5e500c961c09u0g5y$_run_closure1$_closure3.doCall(/Volumes/workplace/python_env/serve/frontend/build.gradle:21)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)
The Report.enabled property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the required property instead. See https://docs.gradle.org/7.3/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled for more details.
        at check_pkr27wjn63qsbncsu3xdv1p7$_run_closure2$_closure9.doCall(/Volumes/workplace/python_env/serve/frontend/tools/gradle/check.gradle:10)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

Fixes #(issue)
#1934

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

testing:

  • run "python binaries/build.py --nightly"
  • result
ls /Volumes/workplace/python_env/serve/binaries/conda/output/osx-64/
current_repodata.json
current_repodata.json.bz2
index.html
repodata.json
repodata.json.bz2
repodata_from_packages.json
repodata_from_packages.json.bz2
torch-model-archiver-0.6.0.dev20221101-py38_0.tar.bz2
torch-model-archiver-0.6.0.dev20221101-py39_0.tar.bz2
torch-workflow-archiver-0.2.4.dev20221101-py38_0.tar.bz2
torch-workflow-archiver-0.2.4.dev20221101-py39_0.tar.bz2
torchserve-0.6.0.dev20221101-py38_0.tar.bz2
torchserve-0.6.0.dev20221101-py39_0.tar.bz2

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning changed the title fix gradle deprecation methon fix gradle deprecation method Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #1936 (f531625) into master (e181fee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1936   +/-   ##
=======================================
  Coverage   41.67%   41.67%           
=======================================
  Files          55       55           
  Lines        2282     2282           
  Branches        1        1           
=======================================
  Hits          951      951           
  Misses       1331     1331           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning lxning merged commit 4303512 into master Nov 2, 2022
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
* fix gradle deprecation methon

* add jcenter as workaround for torchserve-plugins-sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants