Update ubuntu docker version #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuigiCerone
force-pushed
the
update/ubuntu_docker
branch
from
78c54b7
to
e4b2098
Compare
Closed
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 53.31% 53.31%
=======================================
Files 70 70
Lines 3157 3157
Branches 56 56
=======================================
Hits 1683 1683
Misses 1474 1474 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
So https://github.com/actions/runner-images So to answer your question @LuigiCerone the answer is yes to all of the above Regarding testing for anything that's a github action that will be covered by CI so that's easy, for the doc related stuff I think also no test needed But for the existing images you've updated, one more change we'd need to do is go here and make 22.04 optional if people pass it in as an arg since 20.04 is now the default https://github.com/pytorch/serve/blob/master/docker/build_image.sh#L97 And finally for testing can you build the docker images and run a simple inference from our docker/README.md? and attach those logs here. That's the tricky but important part from this PR. If you're up for it lmk because we'd like to merge this change before Dec 2 for a patch release but if not I can either create a new PR or if you're up for it I can push code to your branch directly |
|
Hello @msaroufim , thanks for the useful information! I'll work on this (also the last point) and update the PR in the next few days :) |
maaquib
reviewed
Nov 16, 2022
|
Hello @msaroufim, these are the logs obtained by building locally image |
maaquib
approved these changes
Nov 16, 2022
maaquib
requested changes
Nov 17, 2022
There was a problem hiding this comment.
Register model on Ubuntu20.04+TS0.6.1 Fails with
$ docker run --rm -it -v/home/ubuntu/Downloads/model_store/:/home/model-server/model-store -p8080:8080 -p8081:8081 pytorch/torchserve:latest-cpu serve
...
2022-11-16T23:57:50,418 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - Traceback (most recent call last):
2022-11-16T23:57:50,419 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - File "/home/venv/lib/python3.8/site-packages/ts/model_service_worker.py", line 16, in <module>
2022-11-16T23:57:50,419 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - from ts.metrics.metric_cache_yaml_impl import MetricsCacheYamlImpl
2022-11-16T23:57:50,419 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - File "/home/venv/lib/python3.8/site-packages/ts/metrics/metric_cache_yaml_impl.py", line 5, in <module>
2022-11-16T23:57:50,420 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - import yaml
2022-11-16T23:57:50,420 [WARN ] W-9000-resnet-18_1.0-stderr MODEL_LOG - ModuleNotFoundError: No module named 'yaml'
...
@LuigiCerone Can you add PyYAML as a dependency. This is a miss from #1954
Update: Building with dev image pulls in the dependencies. Seems like we don't use Dockerfile for official release anymore. Approving
maaquib
approved these changes
Nov 17, 2022
agunapal
approved these changes
Nov 17, 2022
msaroufim
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update default from Ubuntu 18.04 to Ubuntu 20.04 (LTS).
Fixes #1889
Type of change
Feature/Issue validation/testing
I need advice on how to test the different updates.
Checklist
20.04be used here instead oflatesttag?20.04be used here instead oflatesttag?20.04be used here instead oflatesttag?20.04be used here instead oflatesttag?20.04be used here instead oflatesttag?This guide refers to18.04version, should it be updated?This example uses18.04versionIn the K8S folder there are some reference to18.04versionEdit after comments: