Upgrade to PyTorch 1.13 #1980
Merged
Upgrade to PyTorch 1.13 #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1980 +/- ##
=======================================
Coverage 53.31% 53.31%
=======================================
Files 70 70
Lines 3157 3157
Branches 56 56
=======================================
Hits 1683 1683
Misses 1474 1474 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lxning
reviewed
Nov 17, 2022
msaroufim
reviewed
Nov 17, 2022
| elif [ $CUDA_VERSION == "cu111" ]; | ||
| then | ||
| BASE_IMAGE="nvidia/cuda:11.1.1-cudnn8-runtime-ubuntu18.04" | ||
| BASE_IMAGE="nvidia/cuda:11.1.1-cudnn8-runtime-ubuntu20.04" |
There was a problem hiding this comment.
NVIDIA doesn't always name their containers consistently, need to manually verify each one of these and make sure they exist
msaroufim
reviewed
Nov 17, 2022
agunapal
commented
Nov 18, 2022
| if hw == 'gpu': | ||
| cmd = 'python ts_scripts/install_dependencies.py --environment dev --cuda cu102' | ||
| if hw == "gpu": | ||
| cmd = "python ts_scripts/install_dependencies.py --environment dev --cuda cu117" |
There was a problem hiding this comment.
Changed default CUDA version for benchmarking to CUDA 11.7 @lxning
…into upgrade_pytorch_113
lxning
approved these changes
Nov 18, 2022
msaroufim
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading PyTorch version to 1.13
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: