add pyyaml in requirements #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namannandan
approved these changes
Nov 30, 2022
namannandan
reviewed
Nov 30, 2022
| @@ -10,3 +10,4 @@ numpy; sys_platform != 'win32' | |||
| numpy==1.19.3; sys_platform == 'win32' #see https://tinyurl.com/y3dm3h86 | |||
| nvgpu; sys_platform != 'win32' | |||
| nvgpu==0.8.0; sys_platform == 'win32' | |||
| pyyaml | |||
There was a problem hiding this comment.
Should we tie version to latest stable release, say 6.0?
There was a problem hiding this comment.
@maaquib please confirm if python metrics requests specific pyyaml version. Thanks!
There was a problem hiding this comment.
There is no requirement for a specific version. We can pin in to the latest one.
msaroufim
approved these changes
Nov 30, 2022
maaquib
approved these changes
Nov 30, 2022
| @@ -10,3 +10,4 @@ numpy; sys_platform != 'win32' | |||
| numpy==1.19.3; sys_platform == 'win32' #see https://tinyurl.com/y3dm3h86 | |||
| nvgpu; sys_platform != 'win32' | |||
| nvgpu==0.8.0; sys_platform == 'win32' | |||
| pyyaml | |||
There was a problem hiding this comment.
There is no requirement for a specific version. We can pin in to the latest one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
#2013
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Before
Logs for Test A
pip list|grep -i yaml
WARNING: You are using pip version 20.2.3; however, version 22.3.1 is available.
You should consider upgrading via the '/Volumes/workplace/python_env/serve/ts_venv/bin/python3 -m pip install --upgrade pip' command.
After
pip list|grep -i yaml
PyYAML 6.0
Checklist: