Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.dev to install gnupg before calling apt-key del 7fa2af80 (fix: #2075) #2076

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

yeahdongcn
Copy link
Contributor

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2075

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • DOCKER_BUILDKIT=1 docker build -f Dockerfile.dev -t pytorch/torchserve-kfs:latest-dev . now can run without any error.
    Logs:
❯ DOCKER_BUILDKIT=1 docker build -f Dockerfile.dev -t pytorch/torchserve-kfs:latest-dev .
[+] Building 514.7s (14/17)                                                                                                                            
 => [compile-image 1/9] FROM docker.io/library/ubuntu:20.04@sha256:0e0402cd13f68137edb0266e1d2c682f217814420f2d43d300ed8f65479b14fb               0.0s
 => CACHED [compile-image 2/9] RUN cp /etc/apt/sources.list /etc/apt/sources.list.bak                                                             0.0s
 => CACHED [compile-image 3/9] RUN sed -i "s@\(archive\|security\|ports\).ubuntu.com@mirrors.tuna.tsinghua.edu.cn@g" /etc/apt/sources.list        0.0s
 => CACHED [compile-image 4/9] RUN --mount=type=cache,id=apt-dev,target=/var/cache/apt   apt-get update &&   DEBIAN_FRONTEND=noninteractive apt-  0.0s
 => CACHED [compile-image 5/9] RUN apt-key del 7fa2af80                                                                                           0.0s
 => CACHED [compile-image 6/9] RUN apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2004/x86_64/3bf863cc.  0.0s
 => CACHED [compile-image 7/9] RUN apt-key adv --fetch-keys https://developer.download.nvidia.com/compute/machine-learning/repos/ubuntu2004/x86_  0.0s
 => CACHED [compile-image 8/9] RUN --mount=type=cache,id=apt-dev,target=/var/cache/apt   DEBIAN_FRONTEND=noninteractive apt-get install --no-ins  0.0s
 => CACHED [compile-image 9/9] RUN python -m pip install -U pip setuptools    

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim msaroufim added the easy label Jan 17, 2023
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #2076 (d68b57b) into master (eced76d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2076   +/-   ##
=======================================
  Coverage   53.38%   53.38%           
=======================================
  Files          71       71           
  Lines        3224     3224           
  Branches       56       56           
=======================================
  Hits         1721     1721           
  Misses       1503     1503           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim merged commit 7924114 into pytorch:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build kserve dev image
3 participants