Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OMP_NUMNER_THREADS in cpu benchmark; increase request to get gpu … #2092

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Jan 25, 2023

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.
add OMP_NUMNER_THREADS in cpu benchmark; increase request to get gpu report for mnist

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

#2090

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning added this to the v0.7.1 milestone Jan 25, 2023
@lxning lxning self-assigned this Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2092 (a19ac3a) into master (d264163) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2092   +/-   ##
=======================================
  Coverage   53.36%   53.36%           
=======================================
  Files          71       71           
  Lines        3225     3225           
  Branches       56       56           
=======================================
  Hits         1721     1721           
  Misses       1504     1504           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lxning , I am not just super sure if we should omp_num_threads=1. Maybe we can discuss it after weekly meeting.

@msaroufim msaroufim requested review from msaroufim and mreso and removed request for msaroufim January 30, 2023 23:35
@lxning lxning merged commit 05e80be into master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v0.7.1 lifecycle
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants