Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tensor parallelism #2741

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Fix tensor parallelism #2741

merged 5 commits into from
Oct 28, 2023

Conversation

mreso
Copy link
Collaborator

@mreso mreso commented Oct 25, 2023

Description

This PR fixes tensor parallelism which was broken due to backend caching mechanism. It also introduces a simple test to detect this kind of issue in the future.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2741 (81d994c) into master (f3d3bb3) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 81d994c differs from pull request most recent head 749e41a. Consider uploading reports for the commit 749e41a to get more accurate results

@@           Coverage Diff           @@
##           master    #2741   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          85       85           
  Lines        3963     3963           
  Branches       58       58           
=======================================
  Hits         2871     2871           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning lxning added this pull request to the merge queue Oct 28, 2023
Merged via the queue into master with commit 7f4419f Oct 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants