KServe gpt-fast example #2895
Merged
KServe gpt-fast example #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzisun
reviewed
Jan 12, 2024
Comment on lines
+1
to
+11
| { | ||
| "instances": [ | ||
| { | ||
| "data": | ||
| { | ||
| "prompt": "The capital of France", | ||
| "max_new_tokens": 50 | ||
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
We should move to use the generate endpoint from open inference protocol once it is out
There was a problem hiding this comment.
Noted. If there's an example please point to it so we can update all our examples and tests
lxning
reviewed
Jan 12, 2024
Comment on lines
+121
to
123
| if isinstance(input_data, str): | ||
| input_data = json.loads(input_data) | ||
|
|
There was a problem hiding this comment.
I don't think this part is needed. could you please check if client pass content type as json?
There was a problem hiding this comment.
It doesn't work without this because kserve is doing some pre-processing and it reads the "data" part as a dict.
I tried this. This didn't work for me. Will track this separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR demonstrates how to serve large language models using KServe
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Checklist: