Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kserve protocol version handling #2957

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Improve kserve protocol version handling #2957

merged 8 commits into from
Feb 29, 2024

Commits on Feb 29, 2024

  1. fix(kserve): ensure there's a default protocol configured 

    The current implementation retrieves the protocol to use from the
"PROTOCOL_VERSION" environment variable however there's no default value
which will trigger an error when served through Kserve as the base class
does a protocol check in the predict method that will fail with None.

The default protocol uses the same value as the base class.
    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    af2f3c7 View commit details
    Browse the repository at this point in the history

  2. fix(kserve): ensure the protocol version configured is a valid value

    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e25f6cd View commit details
    Browse the repository at this point in the history

  3. feat(kserve): make configuration file path configurable 

    This will allow to make the wrapper easier to test beside making
it possible to to change where the file should be looked for.
    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c709369 View commit details
    Browse the repository at this point in the history

  4. test: add KServe wrapper test

    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    675f0ea View commit details
    Browse the repository at this point in the history

  5. test(kserve_wrapper): add protobuf code generation

    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0642144 View commit details
    Browse the repository at this point in the history

  6. fix(kserse): add None handling to the wrapper 

    In case None is passed, keep the default value set in the base __init__.

This makes TorchserveModel behave in the same fashion as the base class.
    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2cf85e3 View commit details
    Browse the repository at this point in the history

  7. refactor(test): rewrite wrapper test to be more complete 

    It now validates that the protocol version is passed properly as well
as failure if an invalid protocol is given.
    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    54f49eb View commit details
    Browse the repository at this point in the history

  8. test: remove kserve pytest tests 

    The overhead required to run the tests outweighs it benefits.

The thing to keep in mind is that the fix allows to run models
through kserve deployments prior to 0.11.1.
    @sgaist
    sgaist committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    15336a2 View commit details
    Browse the repository at this point in the history