Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Enable GCC 5 build #6

Merged
merged 6 commits into from
Jan 28, 2020
Merged

Enable GCC 5 build #6

merged 6 commits into from
Jan 28, 2020

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jan 9, 2020

This build won't pass. Consider this a follow up from #4 to keep track of this.

@pietern pietern requested a review from lw January 28, 2020 12:28
lw
lw approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@lw lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept this with a heavy heart...

tensorpipe/test/util/ringbuffer/ringbuffer_test.cc Outdated Show resolved Hide resolved
@pietern pietern merged commit 068eac9 into master Jan 28, 2020
@pietern pietern deleted the circle-gcc5 branch January 29, 2020 10:21
facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2020
@facebook-github-bot
Refactor shm #6
f717ecb 
Summary: Move includes to implementation file + add required forward declarations.

Reviewed By: lw

Differential Revision: D20747557

fbshipit-source-id: 587e772b35f624f061acb1238eef582aa0af7a5f
mrshenli added a commit that referenced this pull request Jan 12, 2021
@mrshenli
Add CudaDeviceGuard to recvImplFromLoop
1cdee24 
Without this change, I am seeing the following error when running PyTorch's `test_device_map_gpu_non_default` test:

```
[E thread_pool.cpp:112] Exception in thread pool task: CUDA error: invalid device ordinal                                                                       
Exception raised from exchangeDevice at ../c10/cuda/impl/CUDAGuardImpl.h:31 (most recent call first):                                                           
frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6c (0x7fb1de41c9ac in /rai
d/shenli/pytorch/torch/lib/libc10.so)                                                                                                                           
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > co
nst&) + 0xfa (0x7fb1de3e022c in /raid/shenli/pytorch/torch/lib/libc10.so)                                                                                       
frame #2: <unknown function> + 0xc29798 (0x7fb1f32f6798 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)                                                   
frame #3: <unknown function> + 0xc19d91 (0x7fb1f32e6d91 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)                                                   
frame #4: c10::ThreadPool::main_loop(unsigned long) + 0x295 (0x7fb1de40b955 in /raid/shenli/pytorch/torch/lib/libc10.so)                                        
frame #5: <unknown function> + 0xc819d (0x7fb1fece419d in /raid/shenli/miniconda/envs/torchdev/bin/../lib/libstdc++.so.6)                                       
frame #6: <unknown function> + 0x9609 (0x7fb21c06e609 in /lib/x86_64-linux-gnu/libpthread.so.0)                                                                 
frame #7: clone + 0x43 (0x7fb21bf95293 in /lib/x86_64-linux-gnu/libc.so.6)  
```
facebook-github-bot pushed a commit that referenced this pull request Jan 12, 2021
@mrshenli @facebook-github-bot
Add CudaDeviceGuard to recvImplFromLoop (#264)
ac98f40 
Summary:
Without this change, I am seeing the following error when running PyTorch's `test_device_map_gpu_non_default` test:

```
[E thread_pool.cpp:112] Exception in thread pool task: CUDA error: invalid device ordinal
Exception raised from exchangeDevice at ../c10/cuda/impl/CUDAGuardImpl.h:31 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6c (0x7fb1de41c9ac in /rai
d/shenli/pytorch/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > co
nst&) + 0xfa (0x7fb1de3e022c in /raid/shenli/pytorch/torch/lib/libc10.so)
frame #2: <unknown function> + 0xc29798 (0x7fb1f32f6798 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)
frame #3: <unknown function> + 0xc19d91 (0x7fb1f32e6d91 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)
frame #4: c10::ThreadPool::main_loop(unsigned long) + 0x295 (0x7fb1de40b955 in /raid/shenli/pytorch/torch/lib/libc10.so)
frame #5: <unknown function> + 0xc819d (0x7fb1fece419d in /raid/shenli/miniconda/envs/torchdev/bin/../lib/libstdc++.so.6)
frame #6: <unknown function> + 0x9609 (0x7fb21c06e609 in /lib/x86_64-linux-gnu/libpthread.so.0)
frame #7: clone + 0x43 (0x7fb21bf95293 in /lib/x86_64-linux-gnu/libc.so.6)
```

Pull Request resolved: #264

Reviewed By: beauby

Differential Revision: D25887193

Pulled By: mrshenli

fbshipit-source-id: 47fa6b22e88f0a2800c6b20451e74c880715d637
@ghost ghost mentioned this pull request May 3, 2021
Closed
lw pushed a commit that referenced this pull request Sep 20, 2021
@lw
Refactor shm #6
698940b 
Summary: Move includes to implementation file + add required forward declarations.

Reviewed By: lw

Differential Revision: D20747557

fbshipit-source-id: 587e772b35f624f061acb1238eef582aa0af7a5f
lw pushed a commit that referenced this pull request Sep 20, 2021
@mrshenli @lw
Add CudaDeviceGuard to recvImplFromLoop (#264)
a403e67 
Summary:
Without this change, I am seeing the following error when running PyTorch's `test_device_map_gpu_non_default` test:

```
[E thread_pool.cpp:112] Exception in thread pool task: CUDA error: invalid device ordinal
Exception raised from exchangeDevice at ../c10/cuda/impl/CUDAGuardImpl.h:31 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6c (0x7fb1de41c9ac in /rai
d/shenli/pytorch/torch/lib/libc10.so)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > co
nst&) + 0xfa (0x7fb1de3e022c in /raid/shenli/pytorch/torch/lib/libc10.so)
frame #2: <unknown function> + 0xc29798 (0x7fb1f32f6798 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)
frame #3: <unknown function> + 0xc19d91 (0x7fb1f32e6d91 in /raid/shenli/pytorch/torch/lib/libtorch_python.so)
frame #4: c10::ThreadPool::main_loop(unsigned long) + 0x295 (0x7fb1de40b955 in /raid/shenli/pytorch/torch/lib/libc10.so)
frame #5: <unknown function> + 0xc819d (0x7fb1fece419d in /raid/shenli/miniconda/envs/torchdev/bin/../lib/libstdc++.so.6)
frame #6: <unknown function> + 0x9609 (0x7fb21c06e609 in /lib/x86_64-linux-gnu/libpthread.so.0)
frame #7: clone + 0x43 (0x7fb21bf95293 in /lib/x86_64-linux-gnu/libc.so.6)
```

Pull Request resolved: #264

Reviewed By: beauby

Differential Revision: D25887193

Pulled By: mrshenli

fbshipit-source-id: 47fa6b22e88f0a2800c6b20451e74c880715d637
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lw lw lw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pietern @lw