Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job filter for grouped view #205

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fix job filter for grouped view #205

merged 2 commits into from
Feb 18, 2022

Conversation

zengk95
Copy link
Contributor

@zengk95 zengk95 commented Feb 18, 2022

  • This fixes issue grouped view breaks with filters  #199 with making jobs searchable when doing the grouped view. It doesn't automatically expand it but will show you the groupings that contain the jobs
  • Fixes an issue with hovering on a group/workflow. Now has a pointer instead of a cursor when hovering over a group (just swapped around)

See that I searched mac and "other" and "macOS Github Action" groups show up.

image

@vercel
Copy link

vercel bot commented Feb 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/torchci/torchci/7SfnyWbX712wUZQMQ4WEjvJAW1M3
✅ Preview: https://torchci-git-fix-group-hover-torchci.vercel.app

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2022
@zengk95 zengk95 changed the title Fix group hover Fix job filter for grouped view Feb 18, 2022
@zengk95 zengk95 requested review from janeyx99 and suo February 18, 2022 16:49
@zengk95 zengk95 merged commit 3152d15 into main Feb 18, 2022
@suo
Copy link
Member

suo commented Feb 18, 2022

Oops sorry, should have commented on the PR sooner. We actually want the jobs to auto-expand. The typical user flow is:

  • Notice that some job (binary-mac or something) is failing.
  • Send a link to chat with the name_filter set.
  • Someone else can look at it and see the relevant job(s) that the original user was talking about.

Right now, you might just see like "Linux Jobs" or something, which is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants