aws: Add ssh install for windows ami #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
seemethere
commented
Aug 3, 2021
| } | ||
| source_ami = "${data.amazon-ami.windows_root_ami.id}" | ||
| region = "us-east-1" | ||
| ami_regions = ["us-east-1", "us-east-2"] |
There was a problem hiding this comment.
This allows us to copy our AMI to both the us-east-1 and us-east-2 regions without having to do a rebuild
There was a problem hiding this comment.
are we going to support multi-regions? If so, other things might need to be replicated to that region as well
There was a problem hiding this comment.
Currently the canary region for seemethere/test-repo is us-east-2 so that we don't have the potential of reaching capacity for us-east-1
driazati
force-pushed
the
main
branch
2 times, most recently
from
baf79b1
to
0915838
Compare
Also converts packer json to hcl using `packer hcl2_upgrade` Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
force-pushed
the
add_ssh_windows
branch
from
e64258b
to
56e586e
Compare
|
This has been proven to work in our canary environment going to go and merge this so I can build off of it |
PyTorch Dev Infra Backlog
automation
moved this from [Efficiency] GitHub Actions
to Done
Aug 18, 2021
This was referenced Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also converts packer json to hcl using
packer hcl2_upgradeSigned-off-by: Eli Uriegas eliuriegas@fb.com