Update smoke test to use image from Docker hub (#794)

* Update smoke test Docker image build job * Add org-member context
pytorch · May 28, 2020 · 56480e4 · 56480e4
1 parent a48b634
commit 56480e4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 32 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -40,10 +40,7 @@ binary_common: &binary_common
 smoke_test_common: &smoke_test_common
   <<: *binary_common
   docker:
-    - image: 308535385114.dkr.ecr.us-east-1.amazonaws.com/torchtext/smoke_test:d26af7d0-8458-face-book-84239b5c75c0
-      aws_auth:
-        aws_access_key_id: ${ECR_AWS_ACCESS_KEY}
-        aws_secret_access_key: ${ECR_AWS_SECRET_ACCESS_KEY}
+    - image: pytorch/torchtext_smoke_base:latest
 
 jobs:
   circleci_consistency:
@@ -251,21 +248,16 @@ jobs:
     steps:
       - checkout
       - run:
-          name: build_docker image
-          no_output_timeout: "1h"
-          command: |
-            cd .circleci/smoke_test/docker && docker build . -t ${image_name}:${CIRCLE_WORKFLOW_ID}
-      - run:
-          name: upload docker image
+          name: Build and push Docker image
           no_output_timeout: "1h"
           command: |
             set +x
-            export AWS_ACCESS_KEY_ID=${ECR_AWS_ACCESS_KEY}
-            export AWS_SECRET_ACCESS_KEY=${ECR_AWS_SECRET_ACCESS_KEY}
-            eval $(aws ecr get-login --region us-east-1 --no-include-email)
+            echo "${DOCKER_HUB_TOKEN}" | docker login --username "${DOCKER_HUB_USERNAME}" --password-stdin
             set -x
-            docker tag ${image_name}:${CIRCLE_WORKFLOW_ID} 308535385114.dkr.ecr.us-east-1.amazonaws.com/${image_name}:${CIRCLE_WORKFLOW_ID}
-            docker push 308535385114.dkr.ecr.us-east-1.amazonaws.com/${image_name}:${CIRCLE_WORKFLOW_ID}
+            cd .circleci/smoke_test/docker && docker build . -t ${image_name}:${CIRCLE_WORKFLOW_ID}
+            docker tag ${image_name}:${CIRCLE_WORKFLOW_ID} ${image_name}:latest
+            docker push ${image_name}:${CIRCLE_WORKFLOW_ID}
+            docker push ${image_name}:latest
 
   unittest_linux:
     <<: *binary_common
@@ -796,4 +788,5 @@ workflows:
               only:
                 - master
     jobs:
-      - smoke_test_docker_image_build
+      - smoke_test_docker_image_build:
+          context: org-member
diff --git a/.circleci/config.yml.in b/.circleci/config.yml.in
@@ -40,10 +40,7 @@ binary_common: &binary_common
 smoke_test_common: &smoke_test_common
   <<: *binary_common
   docker:
-    - image: 308535385114.dkr.ecr.us-east-1.amazonaws.com/torchtext/smoke_test:d26af7d0-8458-face-book-84239b5c75c0
-      aws_auth:
-        aws_access_key_id: ${ECR_AWS_ACCESS_KEY}
-        aws_secret_access_key: ${ECR_AWS_SECRET_ACCESS_KEY}
+    - image: pytorch/torchtext_smoke_base:latest
 
 jobs:
   circleci_consistency:
@@ -251,21 +248,16 @@ jobs:
     steps:
       - checkout
       - run:
-          name: build_docker image
-          no_output_timeout: "1h"
-          command: |
-            cd .circleci/smoke_test/docker && docker build . -t ${image_name}:${CIRCLE_WORKFLOW_ID}
-      - run:
-          name: upload docker image
+          name: Build and push Docker image
           no_output_timeout: "1h"
           command: |
             set +x
-            export AWS_ACCESS_KEY_ID=${ECR_AWS_ACCESS_KEY}
-            export AWS_SECRET_ACCESS_KEY=${ECR_AWS_SECRET_ACCESS_KEY}
-            eval $(aws ecr get-login --region us-east-1 --no-include-email)
+            echo "${DOCKER_HUB_TOKEN}" | docker login --username "${DOCKER_HUB_USERNAME}" --password-stdin
             set -x
-            docker tag ${image_name}:${CIRCLE_WORKFLOW_ID} 308535385114.dkr.ecr.us-east-1.amazonaws.com/${image_name}:${CIRCLE_WORKFLOW_ID}
-            docker push 308535385114.dkr.ecr.us-east-1.amazonaws.com/${image_name}:${CIRCLE_WORKFLOW_ID}
+            cd .circleci/smoke_test/docker && docker build . -t ${image_name}:${CIRCLE_WORKFLOW_ID}
+            docker tag ${image_name}:${CIRCLE_WORKFLOW_ID} ${image_name}:latest
+            docker push ${image_name}:${CIRCLE_WORKFLOW_ID}
+            docker push ${image_name}:latest
 
   unittest_linux:
     <<: *binary_common
@@ -424,4 +416,5 @@ workflows:
               only:
                 - master
     jobs:
-      - smoke_test_docker_image_build
+      - smoke_test_docker_image_build:
+          context: org-member