setup: Add version for torch dependency #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hard locks the package to a specific version of torch if defined Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
|
Fix #1063 |
|
Do we want to have this on |
mthrok
reviewed
Nov 3, 2020
|
|
||
| pytorch_package_dep = 'torch' | ||
| if pytorch_package_version is not None: | ||
| pytorch_package_dep += "==" + pytorch_package_version |
There was a problem hiding this comment.
Does the cuda version etc factor in here?
There was a problem hiding this comment.
No it does not, but then again we don't account for cuda version in either audio or vision either
|
Just fixed the CI tests. Let's re-run them before merging. |
|
I think CI failures are unrelated to this change, going to go ahead and merge |
zhangguanheng66
pushed a commit
to zhangguanheng66/text
that referenced
this pull request
Nov 20, 2020
setup: Add version for torch dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard locks the package to a specific version of torch if defined
Resolves #1063
Signed-off-by: Eli Uriegas eliuriegas@fb.com