Pipeline bugfixes, docstrings, and tests #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs in
data.Pipeline
, adds docstrings, and adds tests.Bugfixes:
Pipeline.__call__
was accepting positional args, but wasn't forwarding them toPipeline.call
Pipeline.call
, we were runningself(token)
for eachtoken
in an input list, which has the effect of running the entire pipeline on each token of the list. We were correctly executing only the current pipeline'sconvert_token
if the input was not a list. This becomes a bug when you run a chained pipeline and the same step is executed multiple times.Enhancements:
Pipeline.add_after
andPipeline.add_before
now return a reference to the Pipeline (so people don't run into errors doingpipe = pipe.add_*(something)
)convert_token
is actually callableidentity
static method, so we can picklePipeline
objects.