Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration-test.yml #2038

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Update integration-test.yml #2038

merged 1 commit into from
Feb 2, 2023

Conversation

joecummings
Copy link
Contributor

@joecummings joecummings commented Jan 27, 2023 •
edited
Loading

Closes #2018

linux.2xlarge should have enough memory to run the integration tests.

Should only affect the Integration Tests (3.8) CPU CI workflow.

Nayef211
Nayef211 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description with details on why we're adding linux.2xlarge spec and what CI jobs/unit tests it fixes?

@joecummings
Copy link
Contributor Author

Can you please update the PR description with details on why we're adding linux.2xlarge spec and what CI jobs/unit tests it fixes?

Linked relevant issue

@joecummings joecummings merged commit 5b21235 into main Feb 2, 2023
@mthrok
Copy link
Contributor

mthrok commented Feb 2, 2023 •
edited
Loading

@joecummings Is the change correct?
When I created PR #2040, the GHA immediately reported there is no integration test to run.

The workflow is not valid. .github/workflows/integration-test.yml (Line: 12, Col: 5): Unexpected value 'with'

https://github.com/pytorch/text/actions/runs/4070964869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase memory for integration tests
4 participants
@joecummings @mthrok @Nayef211 @facebook-github-bot