Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XLMR and RoBERTa transforms as factory functions #2102

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Add XLMR and RoBERTa transforms as factory functions #2102

merged 3 commits into from
Mar 9, 2023

Conversation

joecummings
Copy link
Contributor

Closes #2002

@Nayef211
Copy link
Contributor

Nayef211 commented Mar 8, 2023

See #2002 (comment)

@joecummings joecummings changed the title Add XLMR and RoBERTa transforms as classes Add XLMR and RoBERTa transforms as factory functions Mar 9, 2023
Nayef211
Nayef211 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped. We should look into how to convert the T5Transform into a factory method next.

@joecummings joecummings merged commit 46e7eef into pytorch:main Mar 9, 2023
@joecummings joecummings deleted the make-transform-into-classes branch March 9, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change transforms in RoBERTa into classes
3 participants
@joecummings @Nayef211 @facebook-github-bot