Optionally ignore utf-8 decoding error when converting std::string to python str. #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D43970697 |
shuminghu
added a commit
to shuminghu/text
that referenced
this pull request
Mar 21, 2023
… python str. (#97282) Summary: X-link: pytorch/pytorch#97282 Pull Request resolved: pytorch#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 37da8270cfd4ae11a43aeb7ab7093edd7d800cee
shuminghu
force-pushed
the
export-D43970697-to-fbsync
branch
from
6dd73da
to
7957a3d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D43970697 |
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 21, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/6473924609918070 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 3202461664252f309ff9a63b35faaf642e92a81a
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 21, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/6473924609918070 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 88954cce2894909bab6a9f7f26d8a41d9652d9fc
|
This pull request was exported from Phabricator. Differential Revision: D43970697 |
shuminghu
added a commit
to shuminghu/text
that referenced
this pull request
Mar 22, 2023
… python str. (#97282) Summary: X-link: pytorch/pytorch#97282 Pull Request resolved: pytorch#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 4988147e6905d1fb8096bf6d172ab8d8952b49b0
shuminghu
force-pushed
the
export-D43970697-to-fbsync
branch
from
7957a3d
to
c560fd9
Compare
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 22, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/4503599786612705 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 262b3e9165e50d893a72f162705956102f1143bc
|
This pull request was exported from Phabricator. Differential Revision: D43970697 |
shuminghu
added a commit
to shuminghu/text
that referenced
this pull request
Mar 22, 2023
… python str. (#97282) Summary: X-link: pytorch/pytorch#97282 Pull Request resolved: pytorch#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 89cee96315440bb54f5d5e70665ac2fc4ee75e1b
shuminghu
force-pushed
the
export-D43970697-to-fbsync
branch
from
c560fd9
to
ed83afd
Compare
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 22, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/4503599786612705 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: a871d2537a6c3aa26f1858be2484320f92184e37
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 22, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/4503599786612705 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: 872c1ea41870d885ad52c39a93735afa43020525
|
This pull request was exported from Phabricator. Differential Revision: D43970697 |
shuminghu
force-pushed
the
export-D43970697-to-fbsync
branch
from
ed83afd
to
145479c
Compare
shuminghu
added a commit
to shuminghu/pytorch
that referenced
this pull request
Mar 22, 2023
… python str. (pytorch#97282) Summary: Pull Request resolved: pytorch#97282 X-link: pytorch/text#2126 When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument. Test Plan: https://www.internalfb.com/intern/testinfra/testrun/4503599786612705 Reviewed By: Nayef211 Differential Revision: D43970697 fbshipit-source-id: d54a7c527d702bec37544442f9ce6e2d441ddc47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When language models use c++ tokenizer, outputs are a c++ strings that are not necessarily valid utf-8 encodings. Default pybind11 casting uses strict utf-8 decoding. We relax the decoding using 'ignore' argument.
Reviewed By: Nayef211
Differential Revision: D43970697