Optionally ignore utf-8 decoding error for scripted C++ tokenizers. #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D44315169 |
…ytorch#2128) Summary: Pull Request resolved: pytorch#2128 Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282). Reviewed By: Nayef211 Differential Revision: D44315169 fbshipit-source-id: a4a60549c8945c8e8594f4f2cc9e7c99d105128d
|
This pull request was exported from Phabricator. Differential Revision: D44315169 |
shuminghu
force-pushed
the
export-D44315169-to-fbsync
branch
from
f874ed1
to
1be3747
Compare
|
Don't need to export diffs to GH |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
…2128) Summary: Pull Request resolved: #2128 Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282). Reviewed By: Nayef211 Differential Revision: D44315169 fbshipit-source-id: d42fcacafd429cf586c631faf826abc172b173d3
Nayef211
pushed a commit
to Nayef211/text
that referenced
this pull request
Mar 29, 2023
…ytorch#2128) Summary: Pull Request resolved: pytorch#2128 Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282). Reviewed By: Nayef211 Differential Revision: D44315169 fbshipit-source-id: d42fcacafd429cf586c631faf826abc172b173d3
Nayef211
added a commit
that referenced
this pull request
Mar 29, 2023
#2134) * Optionally ignore utf-8 decoding error for scripted C++ tokenizers. (#2128) Summary: Pull Request resolved: #2128 Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282). Reviewed By: Nayef211 Differential Revision: D44315169 fbshipit-source-id: d42fcacafd429cf586c631faf826abc172b173d3 * Linter fixes --------- Co-authored-by: Shuming Hu <smhu@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282).
Reviewed By: Nayef211
Differential Revision: D44315169