Add shift-right method to T5 model #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
|
@yohann-benchetrit Can you add a unittest for this? |
Nayef211
reviewed
Mar 28, 2023
There was a problem hiding this comment.
This looks fine to me. @joecummings do you want to take a look and stamp if everything looks okay?
yohann-benchetrit
force-pushed
the
ybenchetrit-add-shift-right-helper-T5
branch
2 times, most recently
from
10dc158
to
a8b8bee
Compare
|
@yohann-benchetrit Looks like there's an error in how the config is being called within _shift_right |
yohann-benchetrit
force-pushed
the
ybenchetrit-add-shift-right-helper-T5
branch
2 times, most recently
from
a84d8a2
to
56d1316
Compare
yohann-benchetrit
force-pushed
the
ybenchetrit-add-shift-right-helper-T5
branch
from
56d1316
to
4708c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
_shift_rightmethod to the T5 Model. This is used for training (see Issue 2127).It shifts an input batch of sequences of token-indices, one index to the right.
Their first token is replaced with the start-of-sequence token, which is the padding-token index for T5 models