Save nesting_field.vocab.freqs #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to look into the original error a bit more into detail, hopefully later today. Thanks! |
|
I believe this is the intended behavior as the vocabs of the nested/nesting fields are intended to be shared link. Feel free to write a test, thanks for the fix! |
|
Thank you for your review! I added tests to existing test functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this PR fixes #372 .
In the currect code,
nestedField.vocab.freqsandnestedField.nesting_field.vocab.freqsare empty.nestedField.vocab.freqsis empty becausebuild_vocab()does not have any argument in this line.nestedField.nesting_field.vocab.freqsis not empty inbuild_vocabfunction, but it becomes empty because the current code assignsnestedField.vocabtonestedField.nesting_field.vocab.In this PR,
nestedField.nesting_field.vocab.freqsis copyed intonestedField.vocab.freqsto accessnestedField.nesting_field.vocab.freqs.Is it expected behavior?
If so, I will add test code to this PR.