Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust is_target in LabelField and update a couple of docstrings #450

Merged
merged 4 commits into from
Oct 16, 2018
Merged

Adjust is_target in LabelField and update a couple of docstrings #450

merged 4 commits into from
Oct 16, 2018

Conversation

harkous
Copy link
Contributor

@harkous harkous commented Oct 14, 2018 •
edited
Loading

closes #449

@mttk
Copy link
Contributor

mttk commented Oct 16, 2018

@harkous can you just fix the travis error (in field.py, the comment line 695 is too long so just break it into two lines)

@harkous
Copy link
Contributor Author

harkous commented Oct 16, 2018

Sure! just did.

@mttk mttk merged commit 4c34efb into pytorch:master Oct 16, 2018
@mttk
Copy link
Contributor

mttk commented Oct 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting is_target to True by default in LabelField
2 participants
@harkous @mttk