Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stop_words conversion to set #458

Merged
merged 2 commits into from
Oct 23, 2018
Merged

fix stop_words conversion to set #458

merged 2 commits into from
Oct 23, 2018

Conversation

artemisart
Copy link
Contributor

fix #457

@mttk
Copy link
Contributor

mttk commented Oct 22, 2018

@artemisart thanks, can you just revert the change in line 215 (back to self.stop_words is not None)? Even though the current version only supports set / None, in which case the expressions are equivalent, I'd prefer the former version.

@artemisart
Copy link
Contributor Author

Ok, done !

@mttk
Copy link
Contributor

mttk commented Oct 22, 2018

Great, will be merged as soon as Travis completes. Thanks a lot for spotting this!

@mttk mttk merged commit 98de87c into pytorch:master Oct 23, 2018
@artemisart artemisart deleted the patch-1 branch October 23, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field.stop_words is overwritten and is no longer a set
2 participants
@artemisart @mttk