Batch first for BPTTIterator #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to bring the repo up to date with recent flake8 fixes before merging this, probably won't have time to do this until the weekend. Thanks for the fix. |
|
Sounds good, cheers. I have a couple of other fixes I wanted to submit, do you want me to wait for the flake8 stuff to be done? |
|
Feel free to submit them now, the flake stuff will be merged into the pull requests when it's done. |
|
It would be nice to have this in, I also came across this bug. |
|
@sidhantnagpal not yet sure for the next release date, this bug is now fixed in master however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transposes the text and target tensors if the text field has
batch_firstset to True.