Fix collisions between oov words and in-vocab words (#447) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this will work for now, but needs to be handled better. |
|
This change broke my code as my unknown token was <UNK> (in capital). I had to manually change <unk> to <UNK> in vocab.py to fix it. |
|
The documentation wasn't updated that Vocab now by default doesn't prepend the unk token anymore (as is being verified in this test) unless passed explicitly. I fixed it here and included in the default specials list to reflect the default behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #447 by verifying if
<unk>is not in specials list and then creates a defaultdict without default_factory.