Update text_normalize() function in text_classification. #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
Jul 26, 2019
|
|
||
|
|
||
| def text_normalize(line): | ||
| """ | ||
| Basic normalization for a line of text. | ||
| Normalization includes | ||
| - lowercasing | ||
| - replacing all non-alphanumeric characters with whitespace | ||
| - complete some basic text normalization for English words. |
There was a problem hiding this comment.
I think it's a good idea to explicitly list the normalizations that are applied so that the user knows exactly what's going to happen without having to look at the code.
added 2 commits
July 26, 2019 10:23
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
| add spaces before and after ')' | ||
| add spaces before and after '!' | ||
| add spaces before and after '?' | ||
| replace ';' multiple spaces with single space |
There was a problem hiding this comment.
typo. replace multiple spaces with single space
There was a problem hiding this comment.
But doesn't that only happen in the end? It looks like the corresponding re only replaces ';' with a single space
There was a problem hiding this comment.
it replaces ';' with a single space. At the very end, multiple spaces will be combined together.
cpuhrsch
reviewed
Jul 26, 2019
cpuhrsch
reviewed
Jul 26, 2019
added 2 commits
July 26, 2019 12:21
cpuhrsch
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.