Drop support for EOL Python 2 #732
Conversation
|
Thanks for the contribution. |
|
I've reverted the changes made by pyupgrade and instead only removed six and Please let me know if you'd like any of the other pyupgrade changes re-applied. |
Thanks for the contribution. LGTM. For now, let's make those necessary changes only. |
| @@ -246,7 +244,7 @@ def test_csv_dataset_quotechar(self): | |||
|
|
|||
| with tempfile.NamedTemporaryFile(dir=self.test_dir) as f: | |||
| for example in example_data: | |||
| f.write(six.b("{}\n".format(",".join(example)))) | |||
| f.write("{}\n".format(",".join(example)).encode("latin-1")) | |||
There was a problem hiding this comment.
Where is the need for encode coming from?
There was a problem hiding this comment.
In particular latin-1 vs. UTF-8?
There was a problem hiding this comment.
From the six documentation:
six.b(data)A “fake” bytes literal. data should always be a normal string literal. ... In Python 3, data is encoded with the latin-1 encoding to bytes.
https://six.readthedocs.io/#six.b
From the six code:
if PY3:
def b(s):
return s.encode("latin-1")
Fixes #725.
Removes six library and upgrades Python syntax.
Also adds
python_requirestosetup.pyto help pip, and Trove classifiers to show support on PyPI.