error out if sentencepiece is not installed #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
Apr 10, 2020
torchtext/data/functional.py
Outdated
| try: | ||
| import sentencepiece as spm | ||
| except ImportError: | ||
| print("Please install sentencepiece") |
There was a problem hiding this comment.
It's better to use "ImportWarning" here
cpuhrsch
reviewed
Apr 10, 2020
torchtext/data/functional.py
Outdated
| try: | ||
| import sentencepiece as spm | ||
| except ImportError: | ||
| print("Please install sentencepiece") |
cpuhrsch
reviewed
Apr 10, 2020
torchtext/data/functional.py
Outdated
| import sentencepiece as spm | ||
| except ImportError: | ||
| print("Please install sentencepiece") | ||
| raise |
There was a problem hiding this comment.
If you're raising the exception it'll fail after all, right? Did you try this with and without sentencepiece available?
cpuhrsch
changed the title
|
I'd move this logic into the top-level "init" so you can be sure it's run immediately on import. |
cpuhrsch
approved these changes
Apr 10, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sp is not released via conda, if users install torchtext's conda wheels, we don't force them to install sp until they use relevant API.