Add binary build #766
Add binary build #766
Conversation
mthrok
force-pushed
the
binary
branch
3 times, most recently
from
8c5332e
to
aef8e4d
Compare
|
@zhangguanheng66 I ported binary build job from torchaudio. The benefit of this is that after conda package is built, it performs import test. So the concern regarding C++ extension proper installation is automatically addressed. |
|
|
||
| test: | ||
| imports: | ||
| - torchtext |
There was a problem hiding this comment.
@zhangguanheng66 This is where the import test is defined.
There was a problem hiding this comment.
This is the old conda build script with some import tests link
There was a problem hiding this comment.
Oh interesting. why was it removed?
| jobs: | ||
| - circleci_consistency | ||
| {{ build_workflows() }} | ||
| # - binary_win_conda: |
There was a problem hiding this comment.
Is this to be fixed in a follow-up PR?
There was a problem hiding this comment.
Not my intent.
I am just keeping what was there and making build_workflows work.
There was a problem hiding this comment.
Should we test the torchtext package with cpp extension on a Windows machine? Although we don't explicitly support Windows, the current package does work on Windows.
There was a problem hiding this comment.
Ideally, we should. torchaudio does not have this but needs this soon.
We can look into how torchvision does it or ask help from someone with Windows experience.
There was a problem hiding this comment.
I'll add unit tests first. Binary builds on Windows will come later.
No description provided.