-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate tests which require external resource #783
Conversation
…dataset.TestDataset)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this PR consolidates the tests that require external resource into test_build.py
. However, why there are some tests missing? For example, test_vocab_download_fasttext_vectors
, test_vocab_extend
etc?
They are not missing. I omitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me!
Thanks! |
Tests that require dataset (either via network access or cache) as following are moved to
test/test_build.py
.In addition to that, the following test modules contain only such tests. so they can simply exclude in
fbcode
.test/test_utils.py
(unchanged)test/data/test_subword.py
(unchanged)