Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix experimental translation dataset #851

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Fix experimental translation dataset #851

merged 5 commits into from
Jun 25, 2020

Conversation

akurniawan
Copy link
Contributor

Fix missing import in the dataset

@akurniawan akurniawan marked this pull request as draft June 25, 2020 03:15
@akurniawan
Copy link
Contributor Author

@zhangguanheng66 this is a fix for translation dataset. There is a missing Vocab import (required for validation in case users provide their own vocabulary objects)

@akurniawan akurniawan marked this pull request as ready for review June 25, 2020 03:32
@zhangguanheng66 zhangguanheng66 merged commit a664981 into pytorch:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akurniawan @zhangguanheng66