Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: Only use the channel we want for test #907

Merged
merged 1 commit into from Aug 6, 2020

Conversation

seemethere
Copy link
Member

Issues were arising when testing release candidates where we would
segfault based on binaries installed from an incorrect channel. This
makes it so that we install from the pytorch-test channel on tags

Similar to pytorch/audio#859

Signed-off-by: Eli Uriegas eliuriegas@fb.com

@seemethere seemethere requested a review from mthrok August 5, 2020 16:22
Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zhangguanheng66
Copy link
Contributor

Will merge after we fix CI on the master branch.

@zhangguanheng66
Copy link
Contributor

@seemethere Please sync with the master branch.

Issues were arising when testing release candidates where we would
segfault based on binaries installed from an incorrect channel. This
makes it so that we install from the pytorch-test channel on tags

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #907 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #907   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files          44       44           
  Lines        3057     3057           
=======================================
  Hits         2365     2365           
  Misses        692      692           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc44243...84196f2. Read the comment docs.

@zhangguanheng66 zhangguanheng66 merged commit fe7ef3a into pytorch:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants