better word vectors + charngram vectors #94

bmccann · 2017-08-15T08:52:19Z

No description provided.

jekbradbury

Looks good; make sure to flake8 though (also, I'll increment the version before merge because this is somewhat breaking and OpenNMT has already frozen the tag they use)

torchtext/datasets/sentiment.py

            Remaining keyword arguments: Passed to the splits method.
        """
        TEXT = data.Field()
        LABEL = data.Field(sequential=False)

        train, val, test = cls.splits(TEXT, LABEL, root=root, **kwargs)

-        TEXT.build_vocab(train, wv_dir=wv_dir, wv_type=wv_type, wv_dim=wv_dim)
+        TEXT.build_vocab(train, vectors=None)


torchtext/vocab.py

+            wv_type = v.split('.')[0]
+            wv_dim = int(v.split('.')[-1][:-1])
+            if wv_type == 'glove':
+                wv_name = '.'.join(v.split('.')[1:-1])


torchtext/vocab.py

+
+    def set_vectors(self, stoi, vectors, dim, unk_init='zero'):
+        self.vectors = torch.Tensor(len(self), dim)
+        self.vectors.normal_(0, 1) if unk_init == 'random' else self.vectors.zero_()


torchtext/vocab.py

+        else:
+            vector = torch.Tensor(1, self.dim).zero_()
+            if self.unk_init == 'random':
+                vector.normal_(0, 1)


jekbradbury · 2017-08-15T21:28:51Z

I'm merging this, but we should be clear in 0.2 release notes about the two API changes this introduces: wv_type etc. being replaced by vectors (fairly straightforward) and the changes to word vector ordering and lookup, which won't affect most people but might be more subtle for anyone who relies on specifics of their current behavior.

bmccann self-assigned this Aug 15, 2017

bmccann requested a review from jekbradbury August 15, 2017 08:52

jekbradbury reviewed Aug 15, 2017

View reviewed changes

bmccann added 2 commits August 15, 2017 09:59

better word vectors + charngram vectors

0d5cc8b

flake 8 and review changes

e876d55

bmccann force-pushed the better_vectors branch from e0b27fc to e876d55 Compare August 15, 2017 10:20

bmccann added 2 commits August 15, 2017 11:05

unk_init as a callback

81c5b28

minor polish

86c895f

jekbradbury merged commit 56e32d0 into master Aug 15, 2017

jekbradbury added the breaking label Aug 17, 2017

jekbradbury deleted the better_vectors branch September 7, 2017 22:42

rachtsingh mentioned this pull request Nov 12, 2017

wv_dir in WikiText2 #174

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

better word vectors + charngram vectors #94

better word vectors + charngram vectors #94

bmccann commented Aug 15, 2017

jekbradbury left a comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

jekbradbury commented Aug 15, 2017 •

edited

Loading

better word vectors + charngram vectors #94

better word vectors + charngram vectors #94

Conversation

bmccann commented Aug 15, 2017

jekbradbury left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

jekbradbury commented Aug 15, 2017 • edited Loading

jekbradbury commented Aug 15, 2017 •

edited

Loading