Set VELOX_DISABLE_GOOGLETEST ON for TorchArrow (#352)

Summary: Disable GTest for TorchArrow Starts to fail with facebookincubator/velox@118feb5 It looks like the compiler flag set at https://github.com/facebookincubator/velox/blob/118feb5d1b946caa614aeb46ccf142c50cd7ddec/CMakeLists.txt#L317 doesn't affects the outer-level project compiler flag (i.e. TorchArrow, which use Velox as a submodule) Thus manually set up `VELOX_DISABLE_GOOGLETEST` compiler flag. Pull Request resolved: #352 Reviewed By: dracifer, bearzx Differential Revision: D36799796 Pulled By: wenleix fbshipit-source-id: b27729a337b1a3ac480b0a2a2d5d5cdbfd3dce6e
pytorch · Jun 2, 2022 · 6262e12 · 6262e12
1 parent ede9c5a
commit 6262e12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/csrc/velox/CMakeLists.txt b/csrc/velox/CMakeLists.txt
@@ -76,7 +76,7 @@ pybind11_add_module(
   VariantToVector.cpp
 )
 
-set(TORCHARROW_COMPILE_DEFINITIONS)
+set(TORCHARROW_COMPILE_DEFINITIONS VELOX_DISABLE_GOOGLETEST)
 
 if(USE_TORCH)
   find_package(Torch REQUIRED)

diff --git a/csrc/velox/velox b/csrc/velox/velox