Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ta.DataFrame/Column to ta.dataframe/column #218

Closed
wants to merge 1 commit into from

Conversation

wenleix
Copy link
Contributor

@wenleix wenleix commented Feb 23, 2022

Summary: This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Differential Revision: D34411896

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Feb 23, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34411896

@wenleix
Copy link
Contributor Author

wenleix commented Feb 23, 2022

See #185

wenleix added a commit to wenleix/torcharrow that referenced this pull request Feb 23, 2022
Summary:
Pull Request resolved: pytorch#218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Differential Revision: D34411896

fbshipit-source-id: 4555587086ae11ff8d5d8c7d041b2ff46a2a2265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34411896

wenleix added a commit to wenleix/torcharrow that referenced this pull request Feb 23, 2022
Summary:
Pull Request resolved: pytorch#218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Reviewed By: OswinC

Differential Revision: D34411896

fbshipit-source-id: 81657dca7bffb5b5cb28a3648b4cc488f2a0cb41
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34411896

wenleix added a commit to wenleix/torcharrow that referenced this pull request Feb 23, 2022
Summary:
Pull Request resolved: pytorch/torchrec#26

Pull Request resolved: pytorch/torchrec#101

Pull Request resolved: pytorch#218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Reviewed By: OswinC

Differential Revision: D34411896

fbshipit-source-id: ac6d3563721e023005b58fdcbd3baec12279e7d3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34411896

Summary:
Pull Request resolved: pytorch/torchrec#26

Pull Request resolved: pytorch/torchrec#101

Pull Request resolved: pytorch#218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Reviewed By: OswinC

Differential Revision: D34411896

fbshipit-source-id: 82d99a155362f77877d00af2b558ff497dd7061a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34411896

facebook-github-bot pushed a commit to pytorch/torchrec that referenced this pull request Feb 23, 2022
Summary:
X-link: #26

Pull Request resolved: #101

X-link: pytorch/torcharrow#218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Reviewed By: OswinC

Differential Revision: D34411896

fbshipit-source-id: b799d7f6e507814c99b1bc524a56ffb0d9fc6471
@wenleix wenleix deleted the export-D34411896 branch February 23, 2022 23:31
YLGH pushed a commit to YLGH/torcharrow that referenced this pull request May 7, 2022
Summary:
This is an automated pull request to update the first-party submodule for [pytorch/FBGEMM](https://github.com/pytorch/FBGEMM).

New submodule commit: pytorch/FBGEMM@0353e78

Pull Request resolved: pytorch/torchrec#218

Test Plan: Ensure that CI jobs succeed on GitHub before landing.

Reviewed By: jianyuh

Differential Revision: D35593464

fbshipit-source-id: a6849dc9f084f0a3ba33aa99422cc6943a93ef4e
facebook-github-bot pushed a commit that referenced this pull request Jun 29, 2022
Summary:
X-link: pytorch/torchrec#26

X-link: pytorch/torchrec#101

X-link: #218

This is the first step; in follow-up diff will rename IDataFrame/IColumn -> DataFrame/Column

Reviewed By: OswinC

Differential Revision: D34411896

fbshipit-source-id: b799d7f6e507814c99b1bc524a56ffb0d9fc6471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants