Rename I{Numerical, String, List, Map}Column #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34572815 |
wenleix
added a commit
to wenleix/torcharrow
that referenced
this pull request
Mar 2, 2022
Summary: Pull Request resolved: pytorch#226 Differential Revision: D34572815 fbshipit-source-id: b82f48b187848af53bbc81f1d74f9c8feff56111
|
This pull request was exported from Phabricator. Differential Revision: D34572815 |
wenleix
force-pushed
the
export-D34572815
branch
from
541369f
to
587323a
Compare
Summary: Pull Request resolved: pytorch#226 Reviewed By: Tianshu-Bao Differential Revision: D34572815 fbshipit-source-id: 013bbd267b58608cfd76fc0b5bc76c9c3208d38e
wenleix
force-pushed
the
export-D34572815
branch
from
587323a
to
a68b840
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34572815 |
YLGH
pushed a commit
to YLGH/torcharrow
that referenced
this pull request
May 7, 2022
Summary: Pull Request resolved: pytorch/torchrec#226 setException and thenTry will cause the exception to be thrown and catch to handle the error logic, this makes the exception handling path extremely expensive, ideally we want to make error path less expensive than normal path to make sure we can recover from an overload situation Reviewed By: yinghai Differential Revision: D35669573 fbshipit-source-id: 69ff294f1c1ec37579c37aeb8090ba62b46bd027
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: #226 Reviewed By: Tianshu-Bao Differential Revision: D34572815 fbshipit-source-id: 1f15b793535c5a2e6684186a03c9bc102b5d17a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D34572815