Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix error when install from source #120

Closed
wants to merge 1 commit into from

Conversation

ice-tong
Copy link

@ice-tong ice-tong commented Jan 12, 2023

Motivation

I got an error when following the steps in the readme to install torcheval from the source.
It seems the packaging is an install requirement but not included in the requirements.txt.

git clone https://github.com/pytorch/torcheval
cd torcheval
pip install -r requirements.txt
python setup.py install

image

Modification

  • Add packaging in the requirements.txt.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2023
@bobakfb
Copy link
Contributor

bobakfb commented Jan 12, 2023

Hi @ice-tong thanks for the commit! This is a temporary issue with torchtnt, one of our requirements, and I know they are fixing it right now. My initial inclination is to just let them have that requirement since we don't need packaging directly to my knowledge.

@ice-tong
Copy link
Author

Cool, I will close this PR~

@ice-tong ice-tong closed this Jan 12, 2023
@bobakfb
Copy link
Contributor

bobakfb commented Jan 12, 2023

thanks again @ice-tong this should be fixed now

@ananthsub
Copy link
Contributor

Fixed by pytorch/tnt#298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants