update num_tasks in click_through_rate metric
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40402724 |
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 94.37% 94.39% +0.01%
==========================================
Files 117 117
Lines 6309 6328 +19
==========================================
+ Hits 5954 5973 +19
Misses 355 355
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ninginthecloud
added a commit
to ninginthecloud/torcheval
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: pytorch#64 click_through_rate metric was introduced by diff , however, I missed that the num_tasks was not included in the original implementation during my review. This diff updates this information. Reviewed By: bobakfb Differential Revision: D40402724 fbshipit-source-id: 9bfb0635a348e33d4c1064b3b38412bc1a846438
ninginthecloud
force-pushed
the
export-D40402724
branch
from
f53698d
to
64b4c4d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40402724 |
ninginthecloud
added a commit
to ninginthecloud/torcheval
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: pytorch#64 click_through_rate metric was introduced by diff , however, I missed that the num_tasks was not included in the original implementation during my review. This diff updates this information. Reviewed By: bobakfb Differential Revision: D40402724 fbshipit-source-id: 4bfb7951df12a6b7e5fb7823ba26ac4cbfc70bd3
ninginthecloud
force-pushed
the
export-D40402724
branch
from
64b4c4d
to
92812d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40402724 |
Summary: Pull Request resolved: pytorch#64 click_through_rate metric was introduced by diff , however, I missed that the num_tasks was not included in the original implementation during my review. This diff updates this information. Reviewed By: bobakfb Differential Revision: D40402724 fbshipit-source-id: 0ac7b73d87e1189876ca55989cb1e9d5d5f0db26
ninginthecloud
force-pushed
the
export-D40402724
branch
from
92812d0
to
f503b84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40402724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
click_through_rate metric was introduced by diff , however, I missed that the num_tasks was not included in the original implementation during my review.
This diff updates this information.
Reviewed By: bobakfb
Differential Revision: D40402724