Support multi-pass prefetch config in CacheParams, and shard estimator will correctly propagate its storage cost #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57055184 |
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
May 14, 2024
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Differential Revision: D57055184
|
This pull request was exported from Phabricator. Differential Revision: D57055184 |
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
May 16, 2024
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Differential Revision: D57055184
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
May 18, 2024
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Reviewed By: sarckk Differential Revision: D57055184
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Reviewed By: sarckk Differential Revision: D57055184
|
This pull request was exported from Phabricator. Differential Revision: D57055184 |
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
May 18, 2024
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Reviewed By: sarckk Differential Revision: D57055184
levythu
added a commit
to levythu/torchrec
that referenced
this pull request
May 18, 2024
…r will correctly propagate its storage cost (pytorch#2000) Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly. Reviewed By: sarckk Differential Revision: D57055184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: After FBGEMM TBE support multipass prefetch mode (see pytorch/FBGEMM#2566 for the full context), this diff will enable TorchRec to pass it all through via CacheParams, and shard estimator will recognize the memory saving accordingly.
Differential Revision: D57055184