[RFC] Allow ModelWrapper and OptimizerWrapper to accept multiple models #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fegin
added a commit
that referenced
this pull request
May 24, 2024
and optimizers ghstack-source-id: 39ee905efb5c05acb62a0676402a4698b86dc6a3 Pull Request resolved: #360
facebook-github-bot
added
the
CLA Signed
fegin
added a commit
that referenced
this pull request
May 24, 2024
and optimizers ghstack-source-id: fa6dc2cafb5dfdfced96896c89711fb6747743c1 Pull Request resolved: #360
fegin
added a commit
that referenced
this pull request
May 24, 2024
and optimizers ghstack-source-id: 190220813ece188728a3c776e6839a323009f719 Pull Request resolved: #360
wconstab
added a commit
that referenced
this pull request
May 24, 2024
wconstab
reviewed
May 24, 2024
wconstab
reviewed
Jun 3, 2024
fegin
added a commit
that referenced
this pull request
Jun 3, 2024
…ls and optimizers ghstack-source-id: 1e995493a6fd0c98a7714262d42d6bc3c2e1fe86 Pull Request resolved: #360
fegin
added a commit
that referenced
this pull request
Jun 3, 2024
…ls and optimizers ghstack-source-id: 749a302774287ac182d649005d1f8d34491ec0d9 Pull Request resolved: #360
Merged
wconstab
approved these changes
Jun 4, 2024
fegin
added a commit
that referenced
this pull request
Jun 5, 2024
and optimizers ghstack-source-id: 190220813ece188728a3c776e6839a323009f719 Pull Request resolved: #360
wconstab
pushed a commit
that referenced
this pull request
Jun 5, 2024
and optimizers ghstack-source-id: 190220813ece188728a3c776e6839a323009f719 Pull Request resolved: #360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):