Fix conversion parity script by defaulting RMSNorm to 1e-6 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for torchtune-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rohan-varma
changed the title
joecummings
reviewed
Jan 4, 2024
torchtune/models/llama2/rms_norm.py
Outdated
| @@ -23,7 +23,7 @@ class RMSNorm(nn.Module): | |||
| eps (float): small value to avoid division by zero. Default: 1e-5 | |||
There was a problem hiding this comment.
Change default in description.
Yes, filed an issue: #153 |
gokulavasan
reviewed
Jan 4, 2024
gokulavasan
reviewed
Jan 4, 2024
joecummings
approved these changes
Jan 4, 2024
|
@pytorch-labs/team-torchtune-repo-owner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Test plan
python -m scripts.llama2_checkpoint.convert_llama2_to_native --checkpoint_path /home/rvarm1/local/dev/assets/llama2-7b/consolidated.00.pth --device cuda:1 &> outpytest tests/torchtune/models/llama2/test_transformer_decoder.py -k test_rms_norm_propagation