Add other flagship instruction dataset builders #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/541
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f033a8 with merge base 34aeb98 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for torchtune-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RdoubleA
approved these changes
Mar 22, 2024
torchtune/datasets/_samsum.py
Outdated
|
|
||
| def samsum_dataset( | ||
| tokenizer: Tokenizer, | ||
| train_on_input: bool = True, |
There was a problem hiding this comment.
I think by default we want to leave train_on_input on False, as I've seen most datasets do mask out the prompt when computing loss (except alpaca)
torchtune/datasets/_grammar.py
Outdated
|
|
||
| def grammar_dataset( | ||
| tokenizer: Tokenizer, | ||
| train_on_input: bool = True, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Based on the RFC #493 and the alpaca dataset refactor PR #520, added 2 other flagship instruction datasets (grammar, samsum) type we'd like to support in torchtune
Changelog
Test plan
Added unit test
E2E test that kick-off finetune training with new added datasets
Discussion item