Replace mention of one-hot encodings with embedding explanation #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview failed. Built with commit 24d3848 https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/5ecc9e6c01d2110006de2ac2 |
|
Yes, indexes, but not in a one-hot-encoded representation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial mentions that we will encode the words as one-hot encoded vectors, but this does not happen anywhere in the code since we are using embedding layers. I removed the paragraph talking about one-hot encodings and replaced it with a short explanation of embeddings.
Let me know if I should rephrase it or leave out the embedding explanation altogether.