Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose frame-rate and cache to video datasets #1356

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Sep 20, 2019

Those arguments have been separated from #1303 to facilitate review.

cc @stephenyan1231

Copy link
Contributor

@stephenyan1231 stephenyan1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to go

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #1356 into master will decrease coverage by 0.42%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   65.34%   64.92%   -0.43%     
==========================================
  Files          75       76       +1     
  Lines        5878     5953      +75     
  Branches      902      911       +9     
==========================================
+ Hits         3841     3865      +24     
- Misses       1765     1817      +52     
+ Partials      272      271       -1
Impacted Files Coverage Δ
torchvision/datasets/ucf101.py 25% <0%> (ø) ⬆️
torchvision/datasets/hmdb51.py 27.65% <0%> (ø) ⬆️
torchvision/datasets/kinetics.py 34.78% <50%> (ø) ⬆️
torchvision/io/__init__.py 100% <0%> (ø) ⬆️
torchvision/io/_video_opt.py 27.02% <0%> (ø)
torchvision/transforms/transforms.py 81.56% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a926b...164eeb3. Read the comment docs.

@fmassa fmassa merged commit 85ffd93 into pytorch:master Sep 20, 2019
@fmassa fmassa deleted the more-args-to-video-datasets branch September 20, 2019 19:59
@fmassa fmassa mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants