Unify video backend #1514
Merged
Unify video backend #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
=========================================
- Coverage 64.66% 63.9% -0.77%
=========================================
Files 83 83
Lines 6461 6507 +46
Branches 992 1004 +12
=========================================
- Hits 4178 4158 -20
- Misses 1984 2056 +72
+ Partials 299 293 -6
Continue to review full report at Codecov.
|
|
@fmassa this PR looks good to me. Thanks for unifying the API from pyav and video_reader backends. |
This was referenced Oct 28, 2019
fmassa
added a commit
that referenced
this pull request
Oct 31, 2019
* Unify video backend interfaces * Remove reference cycle * Make functions private and enable tests on OSX * Disable test if video_reader backend not available * Lint * Fix import after refactoring * Fix lint * Fix merge conflict after cherry-picking for 0.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
set_video_backendto actually do something insideread_videoandread_video_timestamps.It unifies the interface of both backends, and also add separate unittest for each backend.
I had to move the video reader initialization because it was causing reference cycles with the code.
cc @stephenyan1231 for review