Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torchscript issue in ConvTranspose2d #1917

Merged
merged 1 commit into from Feb 25, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Feb 25, 2020

Tests have been failing recently with

RuntimeError:  Tried to access nonexistent attribute or method 'shape' of type 'Optional[Tensor]'.:   File "/opt/conda/conda-bld/torchvision_1582614418949/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.5/site-packages/torchvision/ops/misc.py", line 45             )         ]         output_shape = [x.shape[0], self.bias.shape[0]] + output_shape                                     ~~~~~~~~~~~~~~~ <--- HERE         return _new_empty_tensor(x, output_shape)

most probably due to some changes in torchscript.

This fixes it.

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5306635). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1917   +/-   ##
========================================
  Coverage          ?   0.43%           
========================================
  Files             ?      92           
  Lines             ?    7395           
  Branches          ?    1113           
========================================
  Hits              ?      32           
  Misses            ?    7355           
  Partials          ?       8
Impacted Files Coverage Δ
torchvision/ops/misc.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5306635...4737bbd. Read the comment docs.

@fmassa fmassa merged commit 2937d77 into pytorch:master Feb 25, 2020
@fmassa fmassa deleted the fix-change-in-torchscript branch February 25, 2020 18:14
fmassa added a commit to fmassa/vision-1 that referenced this pull request Jul 8, 2020
facebook-github-bot pushed a commit that referenced this pull request Jul 9, 2020
Summary: Pull Request resolved: #2432

Reviewed By: zhangguanheng66

Differential Revision: D22437817

Pulled By: fmassa

fbshipit-source-id: 4358dd941b90eb222d4ad7e211793bf21653be87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants