Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try building Windows nightlies on CircleCI #2058

Merged
merged 14 commits into from Apr 6, 2020

Conversation

peterjc123
Copy link
Contributor

No description provided.

@peterjc123 peterjc123 force-pushed the circleci_windows branch 3 times, most recently from 86f87e4 to 824f906 Compare April 3, 2020 08:17
@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #2058 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2058   +/-   ##
======================================
  Coverage    0.48%   0.48%           
======================================
  Files          92      92           
  Lines        7411    7411           
  Branches     1128    1128           
======================================
  Hits           36      36           
  Misses       7362    7362           
  Partials       13      13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61538c...cbaa19b. Read the comment docs.

@peterjc123 peterjc123 force-pushed the circleci_windows branch 2 times, most recently from fe10e12 to 88541fc Compare April 3, 2020 09:17
@peterjc123 peterjc123 changed the title [WIP] Try building Windows nightlies on CircleCI Try building Windows nightlies on CircleCI Apr 3, 2020
@@ -397,6 +462,70 @@ workflows:
name: binary_macos_wheel_py3.8_cpu
python_version: '3.8'
wheel_docker_image: pytorch/manylinux-cuda102
- binary_win_wheel_release:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to only run a subset of these for PRs?

Windows executors are about 5x more expensive than linux executors so I wouldn't want this to balloon our CI costs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subset should probably be just latest python version, with latest CUDA and CPU

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to only run a subset of these for PRs?

Windows executors are about 5x more expensive than linux executors so I wouldn't want this to balloon our CI costs.

Done.

@peterjc123 peterjc123 marked this pull request as ready for review April 4, 2020 03:41
@seemethere seemethere merged commit b7a0415 into pytorch:master Apr 6, 2020
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Jun 10, 2020
* Try building Windows nightlies on CircleCI

* Update config.yml

* Merge jobs

* Use cmd

* Debug

* Fix PATH

* Enable build matrix

* Try integrate with regenerate.py

* Fix upload path for Windows wheels

* Bring fewer tests to CI

* Run other tests only on master

* Refactor code

* Use nightly branch

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants