Added number of features in FrozenBatchNorm2d __repr__ #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While BatchNorm layers have extensive information in their repr, FrozenBatchNorm2d has one
fmassa
reviewed
Apr 30, 2020
Since support of Python version ealier than 3.6 have been dropped, f-string can be used.
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
=========================================
- Coverage 0.48% 0.48% -0.01%
=========================================
Files 92 92
Lines 7442 7444 +2
Branches 1135 1135
=========================================
Hits 36 36
- Misses 7393 7395 +2
Partials 13 13
Continue to review full report at Codecov.
|
fmassa
approved these changes
May 4, 2020
There was a problem hiding this comment.
LGTM, thanks a lot @frgfm !
I would just want to ping @seemethere , because with this PR we effectively break support for Python 3.5 due to the f-strings, so I wanted to get his approval first.
seemethere
reviewed
May 4, 2020
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jul 8, 2020
* feat: Added number of features in FrozenBatchNorm2d repr While BatchNorm layers have extensive information in their repr, FrozenBatchNorm2d has one * refactor: Refactored FrozenBatchNorm2d __repr__ * test: Added unittest for FrozenBatchNorm2d __repr__ * style: Removed blank lines in test_ops * refactor: Avoids creating an extra attribute for __repr__ * style: Switched __repr__ to f-string Since support of Python version ealier than 3.6 have been dropped, f-string can be used. * fix: Fixed typo in __repr__ * style: Switched unittest .format to f-string
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 9, 2020
Summary: * feat: Added number of features in FrozenBatchNorm2d repr While BatchNorm layers have extensive information in their repr, FrozenBatchNorm2d has one * refactor: Refactored FrozenBatchNorm2d __repr__ * test: Added unittest for FrozenBatchNorm2d __repr__ * style: Removed blank lines in test_ops * refactor: Avoids creating an extra attribute for __repr__ * style: Switched __repr__ to f-string Since support of Python version ealier than 3.6 have been dropped, f-string can be used. * fix: Fixed typo in __repr__ * style: Switched unittest .format to f-string Pull Request resolved: #2431 Reviewed By: zhangguanheng66 Differential Revision: D22437793 Pulled By: fmassa fbshipit-source-id: 76fd6a42f0b6cabe47c96fcb5a343fe580a0005e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at:
__repr__attribute to theFrozenBatchNorm2dclassSuggestions are welcomed for the proposed formatting!