New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automate uploading to correct upload channel #2204
ci: Automate uploading to correct upload channel #2204
Conversation
d4813a4
to
b7caa89
Compare
You mean https://github.com/pytorch/vision/blob/master/packaging/windows/internal/nightly_defaults.bat#L147? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but I have a question regarding CIRCLE_TAG
command: | | ||
our_upload_channel=nightly | ||
# On tags upload to test instead | ||
if [[ -n "${CIRCLE_TAG}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the CIRCLE_TAG
works? Will we need to first make a release on GitHub (and commit the PR on the tag) so that the job running on the branch gets activated?
What if we need to run fixes on top of the tag, we will need to create new tags with the fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it works exactly that way.
With the upstream pytorch/pytorch
repository we've piloted this for the 1.5.0
release with pretty good success so I'm hoping to bring that same workflow to all of the downstream repositories.
Is there a way to automagically exclude autogenerated files from review? |
There isn't really, sometimes though with the auto-generated files the diff will be too large and they'll exclude themselves |
Automate switch to the test channel on tag and swapping out our BUILD_VERSION for the tag name on tag. Swapping BUILD_VERSION doesn't work on windows, but that will come in a follow up commit. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
b7caa89
to
de949b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Automate switch to the test channel on tag and swapping out our
BUILD_VERSION for the tag name on tag.
Swapping BUILD_VERSION doesn't work on windows, but that will come in a
follow up commit.
cc @peterjc123, could you point me in the direction where the version is defined for windows?
Signed-off-by: Eli Uriegas eliuriegas@fb.com